Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log4j-slf4j-impl version conflicts #34669

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Jan 30, 2024

The deps.toml defines a log4j-slf4j2-impl dependency but not log4j-slf4j-impl. This would sometimes cause version conflicts when running integration tests, because the latter gets transitively pulled by airbyte-protocol.

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 6:36pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 30, 2024
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@postamar postamar force-pushed the postamar/fix-log4j-slf4j-impl-version branch from 8dc54f2 to e6244ed Compare January 30, 2024 17:24
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 30, 2024
@postamar postamar changed the title fix log4j-slf4j-impl version Fix log4j-slf4j-impl version conflicts Jan 30, 2024
@postamar postamar marked this pull request as ready for review January 30, 2024 17:25
@postamar postamar requested a review from a team as a code owner January 30, 2024 17:25
@postamar
Copy link
Contributor Author

postamar commented Jan 30, 2024

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7715491118
✅ Successfully published Java CDK version=0.16.3!

This reverts commit ad1c140.
@postamar postamar enabled auto-merge (squash) January 30, 2024 18:25
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Jan 30, 2024
@postamar postamar enabled auto-merge (squash) January 30, 2024 18:37
@postamar postamar merged commit a814caf into master Jan 30, 2024
19 checks passed
@postamar postamar deleted the postamar/fix-log4j-slf4j-impl-version branch January 30, 2024 18:55
jbfbell pushed a commit that referenced this pull request Feb 1, 2024
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants