Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Postgres: Upgrade CDK with fixed dependency and unpin cloud #34683

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 30, 2024

What

  • CDK had a dependency covergency issue with slf4j leading to NoSuchMethodError in previous version

How

  • Fixed in CDK 0.16.3, Upgrading CDK version and unpinning the cloud

@gisripa gisripa requested a review from a team as a code owner January 30, 2024 22:32
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 5:36pm

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor Author

gisripa commented Jan 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa
Copy link
Contributor Author

gisripa commented Jan 31, 2024

0.6.0 version which is pinned on cloud also has NoSuchMethodError issue happening intermittently.

Sync with this PR's dev image is failing because of aggressive conn-close in bastion, don't see NoSuchMethodError anymore.

@gisripa gisripa force-pushed the gireesh/01-30-postgres/cdk-deps-fix branch from b3b8e3b to 5e854f0 Compare January 31, 2024 17:34
@gisripa gisripa merged commit f5cec3a into master Jan 31, 2024
24 checks passed
@gisripa gisripa deleted the gireesh/01-30-postgres/cdk-deps-fix branch January 31, 2024 17:58
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants