Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Source GitHub: Continue Sync on Stream failure #34700

Merged
merged 18 commits into from Feb 2, 2024

Conversation

artem1205
Copy link
Collaborator

What

Resolve #34677

How

Continue Sync on Stream failure:: Raised error in stream will not lead to sync fail.

Recommended reading order

  1. airbyte-integrations/connectors/source-github/source_github/source.py
  2. airbyte-integrations/connectors/source-github/source_github/streams.py

馃毃 User Impact 馃毃

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview Feb 2, 2024 4:36pm

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 changed the title Source GitHub: Continue Sync on Stream failure 馃悰 Source GitHub: Continue Sync on Stream failure Jan 31, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 31, 2024
@artem1205 artem1205 merged commit 18cfa24 into master Feb 2, 2024
22 of 24 checks passed
@artem1205 artem1205 deleted the artem1205/source-github-34677 branch February 2, 2024 16:55
Copy link

sentry-io bot commented Feb 5, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • 鈥硷笍 airbyte_cdk.utils.traced_exception.AirbyteTracedException: Stream: repository_stats, slice: {'repository': 'OsomePteLtd/aws-xray-sdk-koa'}. Limits for a... /airbyte/integration_code/source_github/streams... View Issue

Did you find this useful? React with a 馃憤 or 馃憥

jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source GitHub: refactor error validation
3 participants