Merge standard sync schedule to standard sync

[tuliren]

What

• This PR resolves Consolidate StandardSyncSchedule into StandardSync #2568.

How

• Add the two fields from StandardSyncSchema to StandardSync.
  • manual (required)
  • schedule
• Add a migration to join StandardSyncSchema onto StandardSync.

Pre-merge Checklist

• Run integration tests
• Publish Docker images

Recommended reading order

1. New schema file: StandardSyncSchedule.yaml.
2. New migration file: MigrationV0_24_0.java.
3. The rest.

[tuliren]

The e2e tests passed locally.

[jrhizor]

yikes

[tuliren]

Not a big deal since this is in test.

[michel-tricot]

do you think something like that would be cleaner like:

schedule:
  type: object
  required:
    - type
  properties:
    type: enum(manual, frequency, other_type)
    frequency:
       type: object   
       properties:
          timeUnit:
             type: string
             enum:
               - minutes
               - hours
               - days
               - weeks
               - months
           units:
             type: integer
    other_type:
       type: object  
       properties:
          // blah 

This way you don't polute StandardSync with manual

[tuliren]

Ideally yes. The json-schema does support union with the oneOf keyword. However, this keyword is not supported by the java code generator jsonschema2pojo: joelittlejohn/jsonschema2pojo#392

[ChristopheDuong]

yes, that's why I had to do what Michel is proposing for the NotificationType and OperatorType fields:

airbyte/airbyte-api/src/main/openapi/config.yaml

Line 1381 in 9e3bfee

# the jsonschema2pojo does not seem to support it yet: https://github.com/joelittlejohn/jsonschema2pojo/issues/392

[tuliren]

Oh, I misunderstood what Michel was proposing. Basically we can make all those enum properties optional fields, and manually make sure only one of them exists on the object. That can work.

[michel-tricot]

Using the enum makes it a valid design (the best would be oneof ofcourse) instead of a hack

[michel-tricot]

Amazing change :) Code is a lot cleaner now! Thanks for updating the different docs along the way