Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-mssql: adopt cleaned-up cdk #34749

Merged
merged 2 commits into from
Feb 9, 2024
Merged

source-mssql: adopt cleaned-up cdk #34749

merged 2 commits into from
Feb 9, 2024

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Feb 1, 2024 •
edited
Loading

Based on #34745. This PR also fixes the broken integration tests which had been re-enabled earlier today. CI is still broken for source-mssql so I ran the tests and the integration tests on my machine successfully.

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 3:30am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@postamar postamar force-pushed the postamar/cdk-cleanup-base-pr branch 4 times, most recently from 1783750 to 44f72bb Compare February 1, 2024 21:23
@postamar postamar force-pushed the postamar/cdk-cleanup-source-mssql branch from 1185e10 to b78ac3f Compare February 1, 2024 21:27
@postamar postamar force-pushed the postamar/cdk-cleanup-base-pr branch 3 times, most recently from 9efadca to 894c72a Compare February 8, 2024 22:25
Base automatically changed from postamar/cdk-cleanup-base-pr to master February 9, 2024 01:46
@postamar postamar force-pushed the postamar/cdk-cleanup-source-mssql branch from b78ac3f to c004ff3 Compare February 9, 2024 01:56
@postamar postamar force-pushed the postamar/cdk-cleanup-source-mssql branch from c004ff3 to 03a2bc5 Compare February 9, 2024 02:00
@postamar postamar force-pushed the postamar/cdk-cleanup-source-mssql branch from 5ceaa0b to a0ccca1 Compare February 9, 2024 03:29
@postamar postamar marked this pull request as ready for review February 9, 2024 03:30
@postamar postamar requested a review from a team as a code owner February 9, 2024 03:30
@postamar
Copy link
Contributor Author

postamar commented Feb 9, 2024

/approve-and-merge reason="source-mssql CI is still broken, reasonable precautions were taken"

@octavia-approvington
Copy link
Contributor

After a careful ML study,
we think this looks okay.
imagine code being okay

@octavia-approvington octavia-approvington merged commit d80a9fc into master Feb 9, 2024
23 of 28 checks passed
@octavia-approvington octavia-approvington deleted the postamar/cdk-cleanup-source-mssql branch February 9, 2024 20:02
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
@postamar @xiaohansong
source-mssql: adopt cleaned-up cdk (#34749)
9cf9722
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@postamar @jatinyadav-cc
source-mssql: adopt cleaned-up cdk (airbytehq#34749)
8751186
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@postamar @jatinyadav-cc
source-mssql: adopt cleaned-up cdk (airbytehq#34749)
ba01b02
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@postamar @jatinyadav-cc
source-mssql: adopt cleaned-up cdk (airbytehq#34749)
13fb2b0
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@postamar @jatinyadav-cc
source-mssql: adopt cleaned-up cdk (airbytehq#34749)
eea642c
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@postamar @xiaohansong
source-mssql: adopt cleaned-up cdk (#34749)
2a62f47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashkulk akashkulk akashkulk approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/mssql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@postamar @octavia-approvington @akashkulk @octavia-squidington-iii