Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: enable connectors tests in draft prs #34756

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Feb 1, 2024

I strongly believe this change is worth it. It's very annoying to have to put the PRs up for review before they're actually ready. Now that we're on github runners there shouldn't be any impediment to running the tests on draft PRs as well.

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 8:58pm

@postamar postamar marked this pull request as ready for review February 1, 2024 20:21
@postamar postamar requested review from a team and stephane-airbyte February 1, 2024 20:21
@postamar
Copy link
Contributor Author

postamar commented Feb 1, 2024

I tested that this works as intended.

@postamar postamar enabled auto-merge (squash) February 1, 2024 20:59
@postamar postamar merged commit deca551 into master Feb 1, 2024
20 checks passed
@postamar postamar deleted the postamar/enable-connector-tests-for-draft-prs branch February 1, 2024 21:15
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants