[source-mongodb-v2] : Fail sync if initial snapshot for any stream fails #34759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
octavia-squidington-iii
added
the
area/documentation
rodireich
approved these changes
Feb 2, 2024
| iterThrewException = true; | ||
| // If hasNext throws an exception, log it and set the flag to indicate that the initial snapshot failed. This indicates to the main iterator | ||
| // to emit state associated with what has been processed so far. | ||
| initialSnapshotFailed = true; |
There was a problem hiding this comment.
Why not throe and exception here instead?
Wouldn't that to the same job?
There was a problem hiding this comment.
Ideally, yes. But we still want to emit the final state before throwing an exception
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the initial snapshot associated with any stream fails, we keep moving onto the next stream. In general, a failing stream should NOT stall progress on existing syncs. However with the way the current connectors are set up, this shows up as a successful sync.
The side-effect of this is that the platform schedules the next sync at the next configured scheduled time. In reality, since the initial snapshot is incomplete, a subsequent sync should be scheduled immediately to make sure the snapshot is completed as soon as possible.
With this change, a failed snapshot for a stream fails the entire sync. The platform retry logic will kick in and continue scheduling syncs until the snapshots are completed***
This also brings the MongoDb behavior at parity with source-postgres and source-mysql.
*Caveat : The sync will fail after 10 attempt
Closes #34392
In the future, perhaps a new protocol message can be emitted to indicate that an initial sync is occurring. The platform can keep scheduling retries in this case until that it no longer sees that message