Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirbyteLib: detect REPL and disable Rich.Live if so #34782

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Feb 2, 2024

We found after more testing that running in a REPL, such as by typing python on its own and then using the interactive REPL there, then the Live() view from Rich would cause glitching.

This update detects a REPL environment and does not print with Live if so.

(Set to auto-merge after approval.)

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 6:27pm

@aaronsteers aaronsteers enabled auto-merge (squash) February 5, 2024 01:42
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, however it would be really cool if we could temporarily enable the live view for the duration of the read and disable once it finishes to have the best of both worlds. I will create a followup issue for this

@aaronsteers aaronsteers merged commit 6e8b87f into master Feb 6, 2024
20 checks passed
@aaronsteers aaronsteers deleted the aj/airbyte-lib/fix-repl-bug branch February 6, 2024 08:26
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants