-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: Make pypi publish enabled for certified connectors #34836
airbyte-ci: Make pypi publish enabled for certified connectors #34836
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Test failure looks like a CI outage:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions! Thanks for reworking your original implem 🙏
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/common.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/common.py
Outdated
Show resolved
Hide resolved
) | ||
|
||
is_python_registry_published = self.context.connector.metadata.get("remoteRegistries", {}).get("pypi", {}).get("enabled", False) | ||
migration_hint = f"Check the airbyte-lib readme under https://github.com/airbytehq/airbyte/blob/master/airbyte-lib/README.md for how to make a connector compatible and configure publishing." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think that the instructions on how enable Pypi publication should not be at the airbyte-lib level but at the connector README.md level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved it over there.
…i-pypi-publish-enforcement
To make sure certified connectors are well supported by airbyte-lib, this PR makes it a requirement to enable pypi publishing for certified connectors in form of an additional check of the connectors test pipeline.