AirbyteLib: Require stream selection #34979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
aaronsteers
commented
Feb 7, 2024
Comment on lines
+279
to
+281
| # TODO: The below assumes all sources can coalesce from incremental sync to | ||
| # full_table as needed. CDK supports this, so it might be safe: | ||
| sync_mode=SyncMode.incremental, |
There was a problem hiding this comment.
This is a drive-by comment-revamp, not directly related to this PR.
octavia-squidington-iii
added
the
area/documentation
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, users will be directed to call "select_streams()" or "select_all_streams()" if they attempt to call "source.read()" without having already done so.
Resolves:
read()PyAirbyte#17This also renames "set_streams()" to "select_streams()" to align with the 'select' verb and 'selected' decriptor used elsewhere.
I've kept 'set_streams()' alive and still works, but it will now emit a
DeprecationWarningwhen called, instructing users they should have calledselect_streams().I've also brought back
get_connector()as an alias ofget_source()using the same deprecation warning approach.