CDK: allow ConnectorStateManager stream_instance_map to take ConfiguredAirbyteStream or Stream #35000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
clnoll
changed the title
clnoll
force-pushed
the
update-state-manager-type
branch
2 times, most recently
from
b389763
to
cbb0a30
Compare
maxi297
approved these changes
Feb 8, 2024
| @@ -38,7 +38,7 @@ class ConnectorStateManager: | |||
|
|
|||
| def __init__( | |||
| self, | |||
| stream_instance_map: Mapping[str, AirbyteStream], | |||
| stream_instance_map: Mapping[str, Union[Stream, AirbyteStream]], | |||
| state: Optional[Union[List[AirbyteStateMessage], MutableMapping[str, Any]]] = None, | |||
| ): | |||
| shared_state, per_stream_states = self._extract_from_state_message(state, stream_instance_map) | |||
There was a problem hiding this comment.
Should the signature for _extract_from_state_message be changed as well?
ConfiguredAirbyteStream (from a catalog) instead of just AirbyteStreams
clnoll
force-pushed
the
update-state-manager-type
branch
from
cbb0a30
to
46d6d21
Compare
|
Here's a the issue to refactor the ConectorStateManger. |
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
…edAirbyteStream or Stream (#35000)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
…edAirbyteStream or Stream (airbytehq#35000)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…edAirbyteStream or Stream (airbytehq#35000)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…edAirbyteStream or Stream (airbytehq#35000)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…edAirbyteStream or Stream (airbytehq#35000)
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
…edAirbyteStream or Stream (#35000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #34540, the
ConnectorStateManager'sstream_instance_mapwas updated to takeConfiguredAirbyteStreams instead ofStreams, because at the point where it was being used by the file-based CDK there was a circular dependency that prevented us from havingAirbyteStreams available.However, when revisiting #34716, which updates usages of the ConnectorStateManager, I realized that the methods called by
ConnectorStateManagerexist on bothStreamandAirbyteStream, and so prefer to take the union of the stream types than to have conditional logic that creates a state manager only if a catalog exists, which we'd have to do to update the Stripe connector.