move test to HttpMocker #35069
Closed
move test to HttpMocker #35069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Base automatically changed from
artem1205/source-github-integration-tests-responses
to
master
February 12, 2024 15:54
askarpets
approved these changes
Feb 15, 2024
| return self | ||
|
|
||
| def with_start_date(self, start_datetime: datetime) -> "ConfigBuilder": | ||
| self._config["start_date"] = start_datetime.isoformat()[:-13] + "Z" |
There was a problem hiding this comment.
Could
start_date.strftime("%Y-%m-%dT%H:%M:%SZ") be used instead of
start_datetime.isoformat()[:-13] + "Z" here?
| @@ -1401,9 +1401,14 @@ def test_stream_contributor_activity_accepted_response(caplog, rate_limit_mock_r | |||
| configured_catalog = { | |||
| "streams": [ | |||
| { | |||
| "stream": {"name": "contributor_activity", "json_schema": {}, "supported_sync_modes": ["full_refresh"],"source_defined_primary_key": [["id"]]}, | |||
| "stream": { | |||
There was a problem hiding this comment.
Should CatalogBuilder be used here?
|
This PR was used to demonstrate the way HttpMocker can replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Proposal for https://github.com/airbytehq/airbyte/pull/34933/files