Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 Updated Qdrant destination icon #35104

Merged
merged 7 commits into from Mar 7, 2024

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented Feb 9, 2024

What

This PR intends to update the Qdrant destination icon with added padding to better fit the catalog card.

Current preview at https://airbyte.com/connectors

Screenshot 2024-02-09 at 22 12 45

@Anush008 Anush008 requested a review from a team as a code owner February 9, 2024 16:45
Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview Mar 7, 2024 2:33pm

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2024

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 馃帀

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@Anush008 Anush008 changed the title Updated Qdrant destination icon 馃摑 Updated Qdrant destination icon Feb 9, 2024
@marcosmarxm
Copy link
Member

Thanks @Anush008 I'm going to ask to our design team validate the change and if the icon follows the standard.

@Anush008
Copy link
Contributor Author

Hi @marcosmarxm. Did you hear back from them?

@marcosmarxm
Copy link
Member

Sorry for the delay folks! This is approved... talking to the team to get this updated asap.

@evantahler
Copy link
Contributor

/approve-and-merge reason="icon update"

@octavia-approvington
Copy link
Contributor

Our work here is done
done

@octavia-approvington octavia-approvington merged commit 6f16ac5 into airbytehq:master Mar 7, 2024
25 of 27 checks passed
@Anush008 Anush008 deleted the qdrant-icon branch March 7, 2024 16:59
@Anush008
Copy link
Contributor Author

Anush008 commented Apr 4, 2024

Hello guys. The icon change doesn't seem to be reflecting at https://airbyte.com/connectors.
Is this change not deployed?

@evantahler
Copy link
Contributor

I think the icon will be updated on the next version bump of the connector (cc @marcosmarxm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants