airbyte-ci: run poetry check before poetry install on poetry package install
#35204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/02-13-airbyte-ci_run_poetry_check_before_poetry_install_on_poetry_package_install
branch
from
b31b4e5
to
aa157aa
Compare
alafanechere
commented
Feb 13, 2024
| @@ -45,7 +45,7 @@ async def _create_builder_container(self, base_container: Container) -> Containe | |||
| Returns: | |||
| Container: The builder container, with installed dependencies. | |||
| """ | |||
| ONLY_BUILD_FILES = ["pyproject.toml", "poetry.lock", "poetry.toml", "setup.py", "requirements.txt"] | |||
| ONLY_BUILD_FILES = ["pyproject.toml", "poetry.lock", "poetry.toml", "setup.py", "requirements.txt", "README.md"] | |||
There was a problem hiding this comment.
As the README.md file is declared in pyproject.toml the poetry check command checks if it's available. It's why we need it at build time.
alafanechere
force-pushed
the
augustin/02-13-airbyte-ci_run_poetry_check_before_poetry_install_on_poetry_package_install
branch
from
aa157aa
to
8a3b485
Compare
alafanechere
changed the base branch from
master
to
augustin/02-13-airbyte-ci_fix_unit_test
alafanechere
merged commit b36c529
into
augustin/02-13-airbyte-ci_fix_unit_test
2 of 3 checks passed
alafanechere
deleted the
augustin/02-13-airbyte-ci_run_poetry_check_before_poetry_install_on_poetry_package_install
branch
alafanechere
added a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #35205
On connector build we want to make sure the
poetry.lockandpyproject.tomlfiles are consistent in terms of dependency declarationHow
Run
poetry checkbeforepoetry install