Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-snowflake: adopt CDK 0.20.4 #35220

Merged
merged 4 commits into from
Feb 14, 2024
Merged

source-snowflake: adopt CDK 0.20.4 #35220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9402a27
source-snowflake: adopt CDK 0.20.4
postamar Feb 13, 2024
94d9ba8
bump version and update changelog
postamar Feb 13, 2024
c3bfef9
add hamcrest dependency
postamar Feb 13, 2024
d8f1cfc
disable integration test failing due to bad credentials
postamar Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions airbyte-integrations/connectors/source-snowflake/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,21 @@
plugins {
id 'application'
id 'airbyte-java-connector'
}

airbyteJavaConnector {
cdkVersionRequired = '0.7.7'
cdkVersionRequired = '0.20.4'
features = ['db-sources']
useLocalCdk = false
}

//remove once upgrading the CDK version to 0.4.x or later
java {
compileJava {
options.compilerArgs.remove("-Werror")
}
}

airbyteJavaConnector.addCdkDependencies()

application {
mainClass = 'io.airbyte.integrations.source.snowflake.SnowflakeSourceRunner'
applicationDefaultJvmArgs = ['-XX:+ExitOnOutOfMemoryError', '-XX:MaxRAMPercentage=75.0']
}

configurations {
all {
resolutionStrategy {
force 'org.jooq:jooq:3.13.4'
}
}
}

dependencies {
implementation group: 'net.snowflake', name: 'snowflake-jdbc', version: '3.14.1'
implementation 'com.zaxxer:HikariCP:5.0.1'

testImplementation 'org.testcontainers:jdbc:1.19.4'
testImplementation 'org.hamcrest:hamcrest-all:1.3'
integrationTestJavaImplementation libs.testcontainers.jdbc
integrationTestJavaImplementation 'org.apache.commons:commons-lang3:3.11'
}
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-snowflake/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ data:
connectorSubtype: database
connectorType: source
definitionId: e2d65910-8c8b-40a1-ae7d-ee2416b2bfa2
dockerImageTag: 0.3.0
dockerImageTag: 0.3.1
dockerRepository: airbyte/source-snowflake
documentationUrl: https://docs.airbyte.com/integrations/sources/snowflake
githubIssueLabel: source-snowflake
Expand Down
2 changes: 2 additions & 0 deletions .../integrations/io/airbyte/integration_tests/sources/SnowflakeSourceAuthAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
import java.nio.file.Path;
import java.util.Properties;
import javax.sql.DataSource;
import org.junit.jupiter.api.Disabled;

@Disabled("The provided refresh token is invalid.")
public class SnowflakeSourceAuthAcceptanceTest extends SnowflakeSourceAcceptanceTest {

@Override
Expand Down
10 changes: 3 additions & 7 deletions ...irbyte/integrations/io/airbyte/integration_tests/sources/SnowflakeSourceDatatypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,9 @@ protected void setupEnvironment(final TestDestinationEnv environment) throws Exc

@Override
protected void tearDown(final TestDestinationEnv testEnv) throws Exception {
try {
final String dropSchemaQuery = String
.format("DROP SCHEMA IF EXISTS %s", SCHEMA_NAME);
database.query(ctx -> ctx.fetch(dropSchemaQuery));
} finally {
dslContext.close();
}
final String dropSchemaQuery = String
.format("DROP SCHEMA IF EXISTS %s", SCHEMA_NAME);
database.query(ctx -> ctx.fetch(dropSchemaQuery));
}

@Override
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/snowflake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ To read more please check official [Snowflake documentation](https://docs.snowfl

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------|
| 0.3.1 | 2024-02-13 | [35220](https://github.com/airbytehq/airbyte/pull/35220) | Adopt CDK 0.20.4 |
| 0.3.1 | 2024-01-24 | [34453](https://github.com/airbytehq/airbyte/pull/34453) | bump CDK version |
| 0.3.0 | 2023-12-18 | [33484](https://github.com/airbytehq/airbyte/pull/33484) | Remove LEGACY state |
| 0.2.2 | 2023-10-20 | [31613](https://github.com/airbytehq/airbyte/pull/31613) | Fixed handling of TIMESTAMP_TZ columns. upgrade |
Expand Down
Loading