Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-sftp: adopt CDK 0.20.4 #35221

Merged
merged 2 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions airbyte-integrations/connectors/source-sftp/build.gradle
Original file line number Diff line number Diff line change
@@ -1,23 +1,13 @@
plugins {
id 'application'
id 'airbyte-java-connector'
}

airbyteJavaConnector {
cdkVersionRequired = '0.13.2'
cdkVersionRequired = '0.20.4'
features = ['db-sources']
useLocalCdk = false
}

//remove once upgrading the CDK version to 0.4.x or later
java {
compileJava {
options.compilerArgs.remove("-Werror")
}
}

airbyteJavaConnector.addCdkDependencies()

application {
mainClass = 'io.airbyte.integrations.source.sftp.SftpSource'
}
Expand All @@ -26,5 +16,5 @@ dependencies {
implementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-csv:2.13.2'
implementation 'com.jcraft:jsch:0.1.55'

testImplementation libs.testcontainers
testImplementation 'org.testcontainers:testcontainers:1.19.4'
}
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-sftp/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: file
connectorType: source
definitionId: a827c52e-791c-4135-a245-e233c5255199
dockerImageTag: 0.2.1
dockerImageTag: 0.2.2
dockerRepository: airbyte/source-sftp
documentationUrl: https://docs.airbyte.com/integrations/sources/sftp
githubIssueLabel: source-sftp
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ public boolean isConnected() {
return channelSftp != null && channelSftp.isConnected();
}

@SuppressWarnings("rawtypes")
public Vector lsFile(SupportedFileExtension fileExtension) {
try {
return channelSftp.ls("*." + fileExtension.typeName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ public Map<String, JsonNode> getFilesSchemas() {
return fileSchemas;
}

@SuppressWarnings("unchecked")
private Set<String> getFileNames() {
checkIfConnected();
Vector<LsEntry> entries = new Vector<>();
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/sftp.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ More formats \(e.g. Apache Avro\) will be supported in the future.

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:-------------------------------------------------------|
| 0.2.2 | 2024-02-13 | [35221](https://github.com/airbytehq/airbyte/pull/35221) | Adopt CDK 0.20.4 |
| 0.2.1 | 2024-01-24 | [34453](https://github.com/airbytehq/airbyte/pull/34453) | bump CDK version |
| 0.2.0 | 2024-01-15 | [34265](https://github.com/airbytehq/airbyte/pull/34265) | Remove LEGACY state flag |
| 0.1.2 | 2022-06-17 | [13864](https://github.com/airbytehq/airbyte/pull/13864) | Updated stacktrace format for any trace message errors |
Expand Down
Loading