Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [source-mssql] skip sql server agent check if EngineEdition == 8 #35368

Merged
merged 7 commits into from
Feb 22, 2024
Merged

✨ [source-mssql] skip sql server agent check if EngineEdition == 8 #35368

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9632b3e
skip sql server agent check if EngineEdition == 8
dwallace0723 Feb 16, 2024
9b17efc
add code comments with links out to sql documentation
dwallace0723 Feb 16, 2024
f9a7d62
fix formatting
dwallace0723 Feb 16, 2024
6363bae
fix data type
dwallace0723 Feb 16, 2024
382ff4a
fix string format
dwallace0723 Feb 16, 2024
272d69d
Merge branch 'master' into dwallace0723/skip-sql-server-agent-check-m…
dwallace0723 Feb 21, 2024
b5641c1
Merge branch 'master' into dwallace0723/skip-sql-server-agent-check-m…
dwallace0723 Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions ...nnectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,18 +417,23 @@ protected void assertCdcSchemaQueryable(final JsonNode config, final JdbcDatabas
// todo: ensure this works for Azure managed SQL (since it uses different sql server agent)
protected void assertSqlServerAgentRunning(final JdbcDatabase database) throws SQLException {
try {
final List<JsonNode> queryResponse = database.queryJsons(connection -> {
final String sql =
"SELECT status_desc FROM sys.dm_server_services WHERE [servicename] LIKE 'SQL Server Agent%' OR [servicename] LIKE 'SQL Server 代理%' ";
final PreparedStatement ps = connection.prepareStatement(sql);
LOGGER.info(String.format("Checking that the SQL Server Agent is running using the query: '%s'", sql));
return ps;
}, sourceOperations::rowToJson);

if (!(queryResponse.get(0).get("status_desc").toString().contains("Running"))) {
throw new RuntimeException(String.format(
"The SQL Server Agent is not running. Current state: '%s'. Please check the documentation on ensuring SQL Server Agent is running.",
queryResponse.get(0).get("status_desc").toString()));
final Int engineEdition = database.queryInt("SELECT ServerProperty('EngineEdition')");
dwallace0723 marked this conversation as resolved.
Show resolved Hide resolved
if (engineEdition == 8) {
LOGGER.info(String.format("Skipping check for whether SQL Server Agent is running. SQL Server Agent is assumed to be running when EngineEdition == '%s'"), engineEdition);
} else {
final List<JsonNode> queryResponse = database.queryJsons(connection -> {
final String sql =
"SELECT status_desc FROM sys.dm_server_services WHERE [servicename] LIKE 'SQL Server Agent%' OR [servicename] LIKE 'SQL Server 代理%' ";
final PreparedStatement ps = connection.prepareStatement(sql);
LOGGER.info(String.format("Checking that the SQL Server Agent is running using the query: '%s'", sql));
return ps;
}, sourceOperations::rowToJson);

if (!(queryResponse.get(0).get("status_desc").toString().contains("Running"))) {
throw new RuntimeException(String.format(
"The SQL Server Agent is not running. Current state: '%s'. Please check the documentation on ensuring SQL Server Agent is running.",
queryResponse.get(0).get("status_desc").toString()));
}
}
} catch (final Exception e) {
if (e.getCause() != null && e.getCause().getClass().equals(com.microsoft.sqlserver.jdbc.SQLServerException.class)) {
Expand Down
Loading