-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize standard test names #3539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the unification 💪🏼 WDYT about "Acceptance test" instead? it's more ubiquitous in test naming and therefore more readily understood imo.
It's also the name we've given the new python test suite. We can change that too, but I think acceptance test is a clearer reflection of their purpose
@sherifnada thats an interesting though. so essentially replace "standard" => "acceptance"? I think that's a good call. |
@sherifnada did as you suggested for all java cases. I have not updated all docs to reflect the new "acceptance" test nomenclature as I think there's a lot in python land that's still the old name? anyway we can figure out what to do with docs next. |
Great! I've created an issue to track: https://github.com/airbytehq/airbyte-internal-issues/issues/93 |
What
Updated Nomenclature Rules
MySqlSourceStandardTest
). All of the transformations that I performed below should follow this nomenclature.MySqlJdbcSourceStandardTest
. This isn't perfectly analogous to the "normal" standard tests naming, but I don't think bringing it in line by using the word Source twice in the class names adds anything but insanity.Transformations
TestDestination
=>DestinationStandardTest
StandardSourceTest
=>SourceStandardTest
PythonTestSource
=>PythonSourceStandardTest
MSSQLIntegrationTest
=>MSSQLSourceStandardTest
DestinationStandardTest
=>BaseDestinationStandardTest
andSourceStandardTest
=>BaseSourceStandardTest
. Decided not to, but honestly it was a coin flip, so if someone wants to make a compelling argument for it, i'd do it.┆Issue is synchronized with this Asana task by Unito