✨Source Amazon Ads: migrate source to YamlDeclarativeSource with custom check_connection

[askarpets]

What

Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/2863

How

• Added DeclarativeSourceAdapter, which is inherited from YamlDeclarativeSource and delegates methods check and streams to the SourceAmazonAds class
• Replaced SourceAmazonAds with DeclarativeSourceAdapter in run.py
• Moved spec to manifest.yaml and deleted spec.yaml

Recommended reading order

1. declarative_source_adapter.py
2. manifest.yaml
3. run.py

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Mar 5, 2024 0:01am

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[girarda]

looks great! just one request for a comment

[askarpets]

Testing summary:

• spec: outputs identical
• check:
  • success: outputs identical
  • failure: outputs identical (except failed rows paths)
• discover: outputs identical (except the order of properties in columns with type of 'object')
• read: outputs identical

@girarda could you please confirm this can be merged?

[girarda]

@askarpets !