[source-mysql] merge state manager #35529

xiaohansong · 2024-02-21T23:35:44Z

What

Merge Iterator state manager to the original state manager.
SourceStateIterator will now pass stream into state manager.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds then checking in your changes
Documentation which references the generator is updated as needed

Updating the Python CDK

Airbyter

Before merging:

Pull Request description explains what problem it is solving
Code change is unit tested
Build and my-py check pass
Smoke test the change on at least one affected connector
- On Github: Run this workflow, passing --use-local-cdk --name=source-<connector> as options
- Locally: airbyte-ci connectors --use-local-cdk --name=source-<connector> test
PR is reviewed and approved

After merging:

Publish the CDK
- The CDK does not follow proper semantic versioning. Choose minor if this the change has significant user impact or is a breaking change. Choose patch otherwise.
- Write a thoughtful changelog message so we know what was updated.
Merge the platform PR that was auto-created for updating the Connector Builder's CDK version
- This step is optional if the change does not affect the connector builder or declarative connectors.

vercel · 2024-02-21T23:35:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 29, 2024 6:14pm

akashkulk · 2024-02-28T19:33:25Z

airbyte-integrations/connectors/source-mysql/build.gradle

You'd need to revert this

akashkulk · 2024-02-28T19:48:14Z

...n/java/io/airbyte/cdk/integrations/source/relationaldb/state/SourceStateIteratorManager.java

Can we possibly rename this to something else? Struggling to understand what exactly to call this

renamed to SourceStateMessageProducer - MySqlInitialLoadStateManager will implement this interface. Think that makes more sense since it's just used to generate state messages and this interface eventually will be the sole place to generate state messages

akashkulk · 2024-02-28T19:57:30Z

.../src/main/java/io/airbyte/integrations/source/mysql/initialsync/MySqlInitialLoadHandler.java

-        new MySqlInitialSyncStateIteratorManager(pair, initialLoadStateManager, incrementalState,
-            syncCheckpointDuration, syncCheckpointRecords);
+    initialLoadStateManager.setStreamStateForIncrementalRunSupplier(streamStateForIncrementalRunSupplier);
+    initialLoadStateManager.setSyncCheckpointDuration(syncCheckpointDuration);


Can we move syncCheckpointDuration and syncCheckpointRecords to the SourceStateIterator in the constructor?

akashkulk

Sorry - let's to the refactor and move syncfrequency to the sourcestateiterator

akashkulk · 2024-02-28T21:19:35Z

...src/main/java/io/airbyte/cdk/integrations/source/relationaldb/state/SourceStateIterator.java

  private boolean hasEmittedFinalState = false;
  private long recordCount = 0L;
  private Instant lastCheckpoint = Instant.now();

-  private final SourceStateIteratorManager sourceStateIteratorManager;
+  public record StateEmitFrequency(long syncCheckpointRecords, Duration syncCheckpointDuration) {}


nit : can we just have a different file for this?

xiaohansong · 2024-02-29T17:55:53Z

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/8100458818
✅ Successfully published Java CDK version=0.23.8!

refactor example - merge state manager

b7d3039

octavia-squidington-iii added area/connectors Connector related issues connectors/source/mysql labels Feb 21, 2024

xiaohansong added 3 commits February 27, 2024 15:16

save work

5f5734b

Merge remote-tracking branch 'origin/master' into xiaohan/state-mgr

5145dfa

format

ca4f73b

octavia-squidington-iii added the CDK Connector Development Kit label Feb 27, 2024

xiaohansong added 3 commits February 27, 2024 15:36

spotbugs

9297a8a

fix test

4e95713

remove unrelated p12 files

763bae7

xiaohansong changed the title ~~refactor example - merge state manager~~ [source-mysql] merge state manager Feb 28, 2024

xiaohansong requested a review from akashkulk February 28, 2024 00:14

xiaohansong marked this pull request as ready for review February 28, 2024 00:14

xiaohansong requested a review from a team as a code owner February 28, 2024 00:14

akashkulk reviewed Feb 28, 2024

View reviewed changes

airbyte-integrations/connectors/source-mysql/build.gradle Outdated

Copy link

Contributor

akashkulk Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to revert this

akashkulk reviewed Feb 28, 2024

View reviewed changes

akashkulk approved these changes Feb 28, 2024

View reviewed changes

akashkulk requested changes Feb 28, 2024

View reviewed changes

xiaohansong added 2 commits February 28, 2024 13:00

put syncFreq in iterator, not manager

5674a6a

rename

e75137a

xiaohansong requested a review from akashkulk February 28, 2024 21:08

akashkulk reviewed Feb 28, 2024

View reviewed changes

xiaohansong added 3 commits February 28, 2024 13:23

move record into a separate file

4ced087

move record into a separate file

49c6ac6

remove prefix

f6bf39b

akashkulk approved these changes Feb 28, 2024

View reviewed changes

xiaohansong added 2 commits February 28, 2024 15:19

upgrade and doc

8825242

Merge remote-tracking branch 'origin/master' into xiaohan/state-mgr

641e9b9

vercel bot deployed to Preview February 28, 2024 23:25 View deployment

Merge branch 'master' into xiaohan/state-mgr

b886184

vercel bot deployed to Preview February 29, 2024 18:00 View deployment

bump

ff2336b

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 29, 2024

vercel bot deployed to Preview February 29, 2024 18:14 View deployment

xiaohansong enabled auto-merge (squash) February 29, 2024 18:26

xiaohansong merged commit 2637e97 into master Feb 29, 2024
28 of 29 checks passed

xiaohansong deleted the xiaohan/state-mgr branch February 29, 2024 18:30

xiaohansong mentioned this pull request Feb 29, 2024

[source-mongodb] record count in state & initial iterator refactor #35669

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[source-mysql] merge state manager #35529

[source-mysql] merge state manager #35529

xiaohansong commented Feb 21, 2024 •

edited

Loading

vercel bot commented Feb 21, 2024 •

edited

Loading

akashkulk Feb 28, 2024

akashkulk Feb 28, 2024

xiaohansong Feb 28, 2024

akashkulk Feb 28, 2024

xiaohansong Feb 28, 2024

akashkulk left a comment

akashkulk Feb 28, 2024

xiaohansong Feb 28, 2024

xiaohansong commented Feb 29, 2024 •

edited by github-actions bot

Loading

[source-mysql] merge state manager #35529

[source-mysql] merge state manager #35529

Conversation

xiaohansong commented Feb 21, 2024 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Airbyter

vercel bot commented Feb 21, 2024 • edited Loading

akashkulk Feb 28, 2024

Choose a reason for hiding this comment

akashkulk Feb 28, 2024

Choose a reason for hiding this comment

xiaohansong Feb 28, 2024

Choose a reason for hiding this comment

akashkulk Feb 28, 2024

Choose a reason for hiding this comment

xiaohansong Feb 28, 2024

Choose a reason for hiding this comment

akashkulk left a comment

Choose a reason for hiding this comment

akashkulk Feb 28, 2024

Choose a reason for hiding this comment

xiaohansong Feb 28, 2024

Choose a reason for hiding this comment

xiaohansong commented Feb 29, 2024 • edited by github-actions bot Loading

xiaohansong commented Feb 21, 2024 •

edited

Loading

vercel bot commented Feb 21, 2024 •

edited

Loading

xiaohansong commented Feb 29, 2024 •

edited by github-actions bot

Loading