🎉 New Connector: Fleetio source

[jmmizerany]

What

• Adding in a new source connector to pull data from the Fleetio API
• For context on what fleetio is, the website is linked here
• The only UI change is adding the Fleetio Source connector , along with our Fleetio icon, to the source collection for connectors

How

• This connector was built using the airbyte low-code CDK
• Currently this support full table replication only, but in future version we will introduce incremental syncing

Recommended reading order

1. x.java
2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

• No breaking changes to Airbyte or this connector

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Connector version is set to 0.0.1
  • Dockerfile has version 0.0.1
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
  • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

[jmmizerany]

Hey all, is there an update on the changes I have pushed? We are wanting to get this live as we have a beta test with some of our end users coming up

[natikgadzhi]

This looks good to me, high level. @marcosmarxm, can you get this over the finish line? What are our requirements for new connectors? Should we obtain a sandbox account and store it internally for tests?

@jmmizerany, would you be able to provide us with a sandbox account that Airbyte could use to run acceptance tests for this connector? I'm not sure how we usually share those credentials ;)

[jmmizerany]

This looks good to me, high level. @marcosmarxm, can you get this over the finish line? What are our requirements for new connectors? Should we obtain a sandbox account and store it internally for tests?

@jmmizerany, would you be able to provide us with a sandbox account that Airbyte could use to run acceptance tests for this connector? I'm not sure how we usually share those credentials ;)

@natikgadzhi Thanks! We have a sandbox account ready to go. Let me know how we can coordinate the next steps

[marcosmarxm]

I ran tests with provided sandbox credentials and some tests are failing. Later this week I'll return with a review and update of changes.

[jmmizerany]

I ran tests with provided sandbox credentials and some tests are failing. Later this week I'll return with a review and update of changes.

Thank you @marcosmarxm Please let me know what I can do to help

[marcosmarxm]

Remove the spec.yaml file as you're setting the spec inside the manifest.yaml

[marcosmarxm]

all objects type must have additionalProperties: true

[natikgadzhi]

Let's get this over the finish line, but then — we should also inline all schemas from json files into the manifest. We have a new tool that can assist with that, airbyte-ci connectors --name source-fleetio migrate_to_inline_schemas in #37649.

[jmmizerany]

Let's get this over the finish line, but then — we should also inline all schemas from json files into the manifest. We have a new tool that can assist with that, airbyte-ci connectors --name source-fleetio migrate_to_inline_schemas in #37649.

Thanks!

[natikgadzhi]

I think for a low-code connector with a bunch of integration tests, this is good enough. For failing cats, this might stop us from doing new changes to this connector (which I would advice — like inlining schemas).

We will reach out if we need to fix them up.