Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Google Ads: Fix error for new customers for incremental events streams #35664

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Feb 27, 2024

What

Fix errors with new customers for incremental events streams. Resolves: https://github.com/airbytehq/oncall/issues/4165

How

In the previous version, the error was raised while trying to get stream slices from the parent stream. The issue was that the parent stream should not be used at all if the customer ID was not synced previously.

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2024 10:53am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues connectors/source/google-ads area/documentation Improvements or additions to documentation labels Feb 27, 2024
@tolik0 tolik0 marked this pull request as ready for review February 27, 2024 17:43
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 27, 2024 17:45
@tolik0 tolik0 self-assigned this Feb 28, 2024
@tolik0 tolik0 force-pushed the tolik0/source-google-ads/fix-incremental-events-stream-new-customers branch from 7ecb4b0 to fc0ee3d Compare March 1, 2024 10:52
@tolik0 tolik0 merged commit df71835 into master Mar 1, 2024
37 checks passed
@tolik0 tolik0 deleted the tolik0/source-google-ads/fix-incremental-events-stream-new-customers branch March 1, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants