Source Monday: fix empty activity logs extractor #35696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
octavia-squidington-iii
added
the
area/documentation
askarpets
approved these changes
Feb 28, 2024
askarpets
reviewed
Feb 28, 2024
| @@ -41,9 +41,8 @@ def extract_records(self, response: requests.Response) -> List[Record]: | |||
| return result | |||
|
|
|||
| for board_data in response_body["data"]["boards"]: | |||
| if not isinstance(board_data, dict): | |||
| if not isinstance(board_data, dict) or not board_data.get("activity_logs"): | |||
There was a problem hiding this comment.
Should there be a unit test for the case when response_body["data"]["boards"] doesn't have the activity_logs section?
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve https://github.com/airbytehq/oncall/issues/4395
How
pass if
activity_logsvalue isnullRecommended reading order
airbyte-integrations/connectors/source-monday/source_monday/extractor.py馃毃 User Impact 馃毃
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.