Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Google Ads: handle 2-Step Verification exception #35709

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Feb 28, 2024

What

Resolve https://github.com/airbytehq/oncall/issues/4106

How

handle 2-Step Verification exception as config error

Recommended reading order

  1. airbyte-integrations/connectors/source-google-ads/source_google_ads/utils.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 7:52pm

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Feb 28, 2024
@artem1205 artem1205 marked this pull request as ready for review February 28, 2024 19:48
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 28, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 28, 2024 19:49
@artem1205 artem1205 merged commit deeb436 into master Feb 29, 2024
32 of 33 checks passed
@artem1205 artem1205 deleted the artem1205/source-google-ads-OC-4106 branch February 29, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants