add a timeout to junit test #35767
Merged
add a timeout to junit test #35767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/03-01-add_a_timeout_to_junit_test
branch
3 times, most recently
from
30b2619
to
a3ea1f2
Compare
rodireich
approved these changes
Mar 1, 2024
|
/publish-java-cdk
|
stephane-airbyte
force-pushed
the
stephane/03-01-add_a_timeout_to_junit_test
branch
from
a6e8756
to
9d4c0de
Compare
|
/publish-java-cdk
|
|
/publish-java-cdk
|
stephane-airbyte
force-pushed
the
stephane/03-01-add_a_timeout_to_junit_test
branch
from
9d4c0de
to
837b908
Compare
|
/publish-java-cdk
|
stephane-airbyte
force-pushed
the
stephane/03-01-add_a_timeout_to_junit_test
branch
from
837b908
to
37d13d4
Compare
xiaohansong
pushed a commit
that referenced
this pull request
Mar 7, 2024
Today there's no clear timeout for tests. The only one that exists is at the github action level, and it has to be conservative at 1h. This change introduces a timeout per test method. The default value is set at 5 minutes per method, and can be overriden on a per method basis via the use of the junit @timeout annotation. We're also fixing a regression in the test ContainerFactory that was sharing less container than was possible. Finally, we're introducing a MdcScope.doNothing to allow using MdcScope in try blocks without triggering a compiler warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there's no clear timeout for tests. The only one that exists is at the github action level, and it has to be conservative at 1h.
This change introduces a timeout per test method. The default value is set at 5 minutes per method, and can be overriden on a per method basis via the use of the junit @timeout annotation.
We're also fixing a regression in the test ContainerFactory that was sharing less container than was possible. Finally, we're introducing a MdcScope.doNothing to allow using MdcScope in try blocks without triggering a compiler warning