New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source File: Add Python 3.11 support #35800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Connector related issues
connectors/source/file
labels
Mar 4, 2024
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Mar 4, 2024
aaronsteers
commented
Mar 5, 2024
@@ -31,17 +31,17 @@ This page contains the setup guide and reference information for the Files sourc | |||
Set this to active if you want to add the [User-Agent header](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent) to requests (inactive by default). | |||
|
|||
#### GCS: Google Cloud Storage | |||
- `Service Account JSON` (Required for **private** buckets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bindipankhudi
approved these changes
Mar 5, 2024
Tested locally with Py3.11 and PyAirbyte. Here is my log, pasting here to help us repeat in future: MyMacBook---GGHWM7QWPJ:PyAirbyte $ pyenv versions
system
* 3.9.17 (set by /Users/ajsteers/.pyenv/version)
* 3.10.12 (set by /Users/ajsteers/.pyenv/version)
3.11.4
MyMacBook---GGHWM7QWPJ:PyAirbyte $ mkdir temp && cd temp
MyMacBook---GGHWM7QWPJ:temp $ python3.11 -m venv py311-test
MyMacBook---GGHWM7QWPJ:PyAirbyte $ cd py311-test/
MyMacBook---GGHWM7QWPJ:py311-test $ bin/pip install airbyte
... [long log omitted] ...
MyMacBook---GGHWM7QWPJ:py311-test a$ bin/python3.11
Python 3.11.7 (main, Dec 4 2023, 18:10:11) [Clang 15.0.0 (clang-1500.1.0.2.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import airbyte as ab
>>> source = ab.get_source("source-file", pip_url="git+https://www.github.com/airbytehq/airbyte.git@aj/source-file/pyarrow-bump#egg=source-file&subdirectory=airbyte-integrations/connectors/source-file")
Installing 'source-file' into virtual environment '/Users/ajsteers/Source/PyAirbyte/py311-test/.venv-source-file'.
... [long log omitted] ...
Connector 'source-file' installed successfully!
For more information, see the source-file documentation:
https://docs.airbyte.com/integrations/sources/file#reference
>>> Basically the process is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: airbytehq/PyAirbyte#95
What
How
How to test
Recommended reading order
n/a
馃毃 User Impact 馃毃
None expected.
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds
then checking in your changesUpdating the Python CDK
Airbyter
Before merging:
--use-local-cdk --name=source-<connector>
as optionsairbyte-ci connectors --use-local-cdk --name=source-<connector> test
After merging: