Source s3 cache connection #35808
Merged
Source s3 cache connection #35808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
clnoll
force-pushed
the
source-s3-cache-connection
branch
from
4ae6d3b
to
ac494b8
Compare
girarda
approved these changes
Mar 5, 2024
| @@ -56,23 +57,24 @@ def s3_client(self) -> BaseClient: | |||
| # list or read files. | |||
| raise ValueError("Source config is missing; cannot create the S3 client.") | |||
|
|
|||
| client_kv_args = _get_s3_compatible_client_args(self.config) if self.config.endpoint else {} | |||
| if self._s3_client is None: | |||
There was a problem hiding this comment.
maybe deserves a comment explaining why we're caching the s3 client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching to the concurrent CDK, we removed caching of the AWS client. This decision was based on local performance testing that showed competition among threads for the connection, which capped performance at a lower value than expected for the concurrency limit.
However, when I was taking a look at S3 performance with concurrency, I noticed that it's actually currently worse than it was with the cached connection. I think this is because the access patterns that we're seeing in practice don't actually require multiple open connections at once, and actually benefit more from the shared connection.
If we see connections with degraded performance with the cached connection, we can consider creating a connection pool as described here.