Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs (ci_credentials): Add remote install instructions via pipx #35809

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Mar 5, 2024

Small docs update to install from branch instead of from local path.

Context:

  • I am starting to test this with PyAirbyte and did not want the version to depend on my airbyte branch being up-to-date with master.

@aaronsteers aaronsteers requested a review from a team as a code owner March 5, 2024 04:48
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 20, 2024 4:55pm

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of the docs as you work! 👏🏼
I don't understand how one line in your addition works, though — perhaps we don't need it?


```bash
pipx install git+https://github.com/airbytehq/airbyte.git#subdirector
y=airbyte-ci/connectors/ci_credentials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That second line is suspicious. What does y= do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh me dumb, I see.

@natikgadzhi natikgadzhi merged commit 66c7fef into master Apr 20, 2024
26 of 29 checks passed
@natikgadzhi natikgadzhi deleted the aj/ci_credentials/remote-install branch April 20, 2024 16:55
strosek pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants