New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Bing Ads: new streams: Audience Performance Report, Goals And Funnels Report, Product Dimension Performance Report #35812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/bing-ads
labels
Mar 5, 2024
askarpets
approved these changes
Mar 7, 2024
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_report_stream.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_report_stream.py
Outdated
Show resolved
Hide resolved
...s/connectors/source-bing-ads/unit_tests/resource/response/goals_and_funnels_report_daily.csv
Outdated
Show resolved
Hide resolved
.../source-bing-ads/unit_tests/resource/response/goals_and_funnels_report_daily_incremental.csv
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/bing-ads
team/connectors-python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resolved: https://github.com/airbytehq/airbyte-internal-issues/issues/978, #17383, https://github.com/airbytehq/airbyte-internal-issues/issues/977
How
Added new streams and integrations test for them as streams are empty in our test account. Also updated documentation with info about data accuracy for reports and their columns.
Recommended reading order
airbyte-integrations/connectors/source-bing-ads/source_bing_ads/report_streams.py
airbyte-integrations/connectors/source-bing-ads/source_bing_ads/schemas
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/
🚨 User Impact 🚨
No breaking changes.