✨ Source Microsoft SharePoint: Add parsing shared files #35830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
tolik0
force-pushed
the
tolik0/source-microsoft-sharepoint/add-shared-drives
branch
from
e037117
to
243ef28
Compare
lazebnyi
approved these changes
Mar 6, 2024
| item_url = f"{base_url}/items/{object_id}" | ||
| item_response = requests.get(item_url, headers=headers) | ||
| if item_response.status_code != 200: | ||
| raise RuntimeError(f"Error retrieving shared object: {item_response.status_code}") |
There was a problem hiding this comment.
We need specified more user friendly error message with more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Iterating over shared objects is implemented using the requests library, as office365 doesn't support getting items using drive ID and object ID.
Add a new parameter, search_scope, to select where to search for the files.
Fix file paths by adding the drive URL to the file path to differentiate between files from different drives.