New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Vector destination tests and move to Poetry #35911
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Milvus account has reached OpenAI quota:
Update: Weaviate is showing the same issue. (OpenAI quota exceeded.) |
Re: Pinecone failures looks like breaking changes in the pinecone library. Probably need to pin to prior version:
Update: I've pinned to <3.0. For future ref, migration guide is here. |
I've updated the configs in GSM so that each of these three uses embeddings "mode": "fake" instead of "mode": "openai". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the OpenAI quota issues, are these all the changes we need to comply with the new connector requirements?
As of now I'm using this PR as a placeholder and vehicle to run/debug CI tests. It only contains one fix as of now (the pinecone library pin) but the idea is that before merging we'll get all passing tests again. |
assuming we are good for now then? |
Still a bit more work to do. One connector (Vectara, I think) went green after this. Another (pinecone) appears to need a more specific version to be pinned, and the third (weaviate) had some integration tests that strictly required the OpenAI key. All of these also have the (new) requirement to be on Poetry. If we don't fix that poetry failure, we'll be blind to other failure types because status will stay constantly red. |
bindipankhudi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Tests for Milvus, Pinecone, and Weaviate destinations are green now. Changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved!
This is huge to have these passing tests again!
Two points for follow-up, but non-blocking:
- The
run.run
CLI references in thepyproject.toml
files won't work yet, but also they shouldn't hurt anything in the meanwhile. - It's probably worth looping back sometime soon to bump the CDK versions to latest. The version here is 57ish in most cases, whereas I think the latest version is around 75 now.
I think we can handle both in future cycles.
Destinations addressed in this pull request