Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Heartbeating External Documentation. #35932

Merged
merged 5 commits into from Mar 8, 2024
Merged

Better Heartbeating External Documentation. #35932

merged 5 commits into from Mar 8, 2024

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Mar 8, 2024 •
edited

In,

  1. https://github.com/airbytehq/airbyte-platform-internal/commit/96baf5b990650fb32a332d6d6baa063f673e3699
  2. https://github.com/airbytehq/airbyte-platform-internal/pull/11595

we improve our heartbeat error messages and point users to this external document.

Here, we improve external documentation to help users understand what is happening and what they can do.

@vercel Vercel
Copy link

vercel bot commented Mar 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 11:13pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 8, 2024
tryangul
tryangul approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@tryangul tryangul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small grammar tweaks but LGTM 🚢

@davinchia davinchia merged commit e66ec11 into master Mar 8, 2024
25 of 26 checks passed
@davinchia davinchia deleted the davinchia/better-heartbeat-docs branch March 8, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

@tryangul tryangul tryangul approved these changes

@jpefaur jpefaur Awaiting requested review from jpefaur

@evantahler evantahler Awaiting requested review from evantahler

@nataliekwong nataliekwong Awaiting requested review from nataliekwong

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davinchia @benmoriceau @tryangul @octavia-squidington-iii