🐛 Source Shopify: Fixed bug when start date was not provided, but the stream was using it
#35952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
tolik0
reviewed
Mar 11, 2024
airbyte-integrations/connectors/source-shopify/source_shopify/streams/base_streams.py
Outdated
Show resolved
Hide resolved
tolik0
approved these changes
Mar 11, 2024
|
Do we need to add |
darynaishchenko
approved these changes
Mar 11, 2024
askarpets
approved these changes
Mar 11, 2024
| # but if the customer has already switched to the new version, | ||
| # corrected the old config and switches back to the new version, | ||
| # we should try to migrate the modified old custom reports. | ||
| none_values: List[str] = [None, "None"] |
There was a problem hiding this comment.
Could this be a tuple? Sorry
There was a problem hiding this comment.
Sure, but what is wrong having the List here?
airbyte-integrations/connectors/source-shopify/source_shopify/streams/base_streams.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolving:
How
start datevalue andfallbackto thedefault_start_datevalue of2018-01-01, if thestart_datewas not provided in theconfigconfig migrationto gracefully migrate the configs with no / badstart_datevaluesunit_test