Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Recharge: Add sort_by to guarantee the records are in ASC order #35982

Merged
merged 2 commits into from Mar 12, 2024

Conversation

bazarnov
Copy link
Collaborator

What

Resolving:

How

  • added sort_by query param to the request_params to guarantee the records are returned in asc order
  • adjusted existing unit_tests to cover the case

Is this a Breaking Change?

No.

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 11:37am

@bazarnov bazarnov self-assigned this Mar 12, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 12, 2024
@bazarnov bazarnov marked this pull request as ready for review March 12, 2024 11:34
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 12, 2024 11:35
@bazarnov bazarnov merged commit 0113c52 into master Mar 12, 2024
35 checks passed
@bazarnov bazarnov deleted the baz/source/recharge/fix-missing-records-query-param branch March 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/recharge
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

5 participants