Source Facebook Marketing: fix start_date selection behaviour #36025
Conversation
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
| @@ -314,6 +314,10 @@ def _get_start_date(self) -> Mapping[str, pendulum.Date]: | |||
| start_date = min(start_date, refresh_date) | |||
| else: | |||
| start_date = self._start_date | |||
|
|
|||
| if start_date < self._start_date: | |||
| logger.warning(f"Ignore provided state and start sync from start_date ({self._start_date}).") | |||
There was a problem hiding this comment.
nit: can we have the message like this?
logger.warning(f"Starting the sync from: ({self._start_date}). The provided state: {%} was ignored.")Not sure about the state mention in this context, but it seems like one of [start_date, self._start_date, oldest_date] ?
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
@artem1205 I want to check - when we are moving up the start date, are the end dates for the slices adjusted accordingly? Looking into this and I want to make sure it is addressed (since the start and end date that were overlapping were both before the user's prescribed start date, I'm hoping that this was caused by the same root cause but feel free to redirect me if you think otherwise) |
|
@erohmensing , Yep, it should be covered. see unit tests starting from |
…cebook-OC-4495-2 # Conflicts: # airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml # airbyte-integrations/connectors/source-facebook-marketing/pyproject.toml # docs/integrations/sources/facebook-marketing.md
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
What
Resolve https://github.com/airbytehq/oncall/issues/4495
How
fix logic of start_date to sync from;
considering lookback window do not sync data prior start_date
Recommended reading order
airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.