Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Chargebee: Declare Unexpected Fields #36037

Merged
merged 8 commits into from
Mar 14, 2024
Merged

Source Chargebee: Declare Unexpected Fields #36037

merged 8 commits into from
Mar 14, 2024

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Mar 13, 2024 •
edited
Loading

What

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 3:34pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee labels Mar 13, 2024
@pnilan
Modifies custom transformation component to remove field that begin w…
f94f8b1 
…ith `cf_` after they've been added to new `custom_fields` list
@pnilan
Update PR number
f7f9799
@pnilan pnilan marked this pull request as ready for review March 13, 2024 22:46
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 13, 2024 22:48
@pnilan pnilan requested review from maxi297 and bazarnov March 13, 2024 23:28
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 14, 2024 08:22
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 14, 2024 08:41
maxi297
maxi297 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given API Sources is fine with this change, I'm also fine with it. In order words, conditional approval to API Sources approval

@pnilan pnilan merged commit 58eddcc into master Mar 14, 2024
33 checks passed
@pnilan pnilan deleted the pnilan/source-chargebee-field-validation branch March 14, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov bazarnov approved these changes

@artem1205 artem1205 artem1205 approved these changes

@maxi297 maxi297 Awaiting requested review from maxi297

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pnilan @maxi297 @bazarnov @artem1205 @octavia-squidington-iii