Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oracle_x_norm #36048

Merged
merged 1 commit into from
Apr 11, 2024
Merged

oracle_x_norm #36048

merged 1 commit into from
Apr 11, 2024

Conversation

jbfbell
Copy link
Contributor

@jbfbell jbfbell commented Mar 14, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 10:45pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 14, 2024
@jbfbell Graphite App
Copy link
Contributor Author

jbfbell commented Mar 14, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jbfbell and the rest of your teammates on Graphite Graphite

@jbfbell jbfbell mentioned this pull request Mar 14, 2024
Merged
@jbfbell jbfbell mentioned this pull request Mar 14, 2024
Merged
@jbfbell jbfbell force-pushed the jbfbell/cdk_prep_for_remove_norm branch from a895b20 to 9d9103e Compare March 16, 2024 02:47
@jbfbell jbfbell force-pushed the jbfbell/cdk_prep_for_remove_norm branch from 9d9103e to a2c7b0e Compare April 5, 2024 22:14
@jbfbell jbfbell force-pushed the jbfbell/cdk_prep_for_remove_norm branch from a2c7b0e to 312d2ad Compare April 5, 2024 22:21
@jbfbell jbfbell force-pushed the jbfbell/oracle_x_norm branch 2 times, most recently from b89dbe1 to 6c94d96 Compare April 5, 2024 22:24
@jbfbell jbfbell marked this pull request as ready for review April 5, 2024 22:44
@jbfbell jbfbell requested a review from a team as a code owner April 5, 2024 22:44
@jbfbell jbfbell force-pushed the jbfbell/cdk_prep_for_remove_norm branch from 645c8e0 to 332c782 Compare April 9, 2024 22:03
Base automatically changed from jbfbell/cdk_prep_for_remove_norm to master April 10, 2024 04:37
katmarkham
katmarkham requested changes Apr 11, 2024
View reviewed changes
...egrations/connectors/destination-oracle-strict-encrypt/src/test/resources/expected_spec.json Show resolved Hide resolved
...egrations/connectors/destination-oracle-strict-encrypt/src/test/resources/expected_spec.json Show resolved Hide resolved
...egrations/connectors/destination-oracle-strict-encrypt/src/test/resources/expected_spec.json Show resolved Hide resolved
...egrations/connectors/destination-oracle-strict-encrypt/src/test/resources/expected_spec.json Show resolved Hide resolved
...egrations/connectors/destination-oracle-strict-encrypt/src/test/resources/expected_spec.json Show resolved Hide resolved
docs/integrations/destinations/oracle-migrations.md Outdated Show resolved Hide resolved
docs/integrations/destinations/oracle-migrations.md Show resolved Hide resolved
docs/integrations/destinations/oracle-migrations.md Outdated Show resolved Hide resolved
docs/integrations/destinations/oracle-migrations.md Outdated Show resolved Hide resolved
docs/integrations/destinations/oracle-migrations.md Outdated Show resolved Hide resolved
@jbfbell jbfbell requested a review from katmarkham April 11, 2024 18:49
@jbfbell jbfbell merged commit b0d0dcd into master Apr 11, 2024
25 of 29 checks passed
@jbfbell jbfbell deleted the jbfbell/oracle_x_norm branch April 11, 2024 23:01
@hugovandernotte
Copy link

Hey @jbfbell,

I think that since your changes, this issue started to happen: #37400

@evantahler evantahler mentioned this pull request May 1, 2024
Closed
@hugovandernotte
Copy link

hugovandernotte commented May 5, 2024 •
edited
Loading

Hey @jbfbell,

I think that since your changes, this issue started to happen: #37400

@stephane-airbyte @katmarkham @edgao any chances that you fix the bug introduced by this merge? The destination is not usable at all for oracle 19c, since that, as the airbyte internal columns types are not supported :)

@evantahler
Copy link
Contributor

Let's keep the converstation in #37400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@stephane-airbyte stephane-airbyte stephane-airbyte left review comments

@katmarkham katmarkham katmarkham approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/oracle connectors/destination/oracle-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jbfbell @hugovandernotte @evantahler @edgao @katmarkham @stephane-airbyte @octavia-squidington-iii