Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amazon Ads - Update Deprecated Streams #36169

Merged
merged 37 commits into from
Mar 25, 2024

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Mar 15, 2024

What

  • Updates the following streams due to API endpoint deprecation:
    • SponsoredBrandsCampaigns
    • SponsoredBrandsAdGroups
    • SponsoredProductCampaigns
    • SponsoredProductAdGroups
    • SponsoredProductAdGroupBidRecommendations
    • SponsoredProductKeywords
    • SponsoredProductNegativeKeywords
    • SponsoredProductCampaignNegativeKeywords
    • SponsoredProductAds
    • SponsoredProductTargetings
    • SponsoredProductAdGroupsSuggestedKeywords
  • Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/2440
  • Updates SponsoredBrands integration testing to reflect new POST methods, JSON payload, and new pagination strategy.
  • Updates unit testing to include POST requests and updated state filter.

Breaking Changes

The following streams have breaking changes due to removed fields from returned records:

  • SponsoredBrandsCampaigns
  • SponsoredBrandsAdGroups
  • SponsoredProductCampaigns
  • SponsoredProductAdGroupBidRecommendations

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 9:09pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 20, 2024
@pnilan pnilan marked this pull request as ready for review March 20, 2024 17:32
@octavia-squidington-iv octavia-squidington-iv requested review from a team March 20, 2024 17:33
@pnilan pnilan requested a review from girarda March 25, 2024 21:45
@pnilan pnilan merged commit ecdb0d7 into master Mar 25, 2024
30 of 33 checks passed
@pnilan pnilan deleted the pnilan/source-amazon-ads-issue-2440 branch March 25, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants