airbyte-ci: allow empty pull request number for migrate-base-image cmd
#36220
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
I'm in for this change - added minor suggestions. I'm wondering if we should use a placeholder for PR number instead of not writing the entry at all.
The missing changelog entry will get caught by CI so I don't really mind the final behavior you'll pick.
Would you consider making the same change to the bump_version command which has the same annoying requirement for a PR number?
And please don't forget to bump the version in pyproject.toml and add a changelog entry in README :) (sorry, no autobump for this package)
...te-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/migrate_to_base_image/commands.py
Outdated
Show resolved
Hide resolved
...te-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/migrate_to_base_image/commands.py
Show resolved
Hide resolved
...te-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/migrate_to_base_image/pipeline.py
Outdated
Show resolved
Hide resolved
...te-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/migrate_to_base_image/pipeline.py
Outdated
Show resolved
Hide resolved
|
oh.. Running local formatting requires docker! 🙈 |
|
@alafanechere please teach me to run formatters locally and let's make sure it's in the root-level CONTRIBUTING or something. I just ran Anyway, done with feedback here. |
It is documented here https://docs.airbyte.com/contributing-to-airbyte/resources/code-formatting |
|
@natikgadzhi thanks for the changes. You might also want to update the documentation of the command you changed |
|
Fixed version, fixed readme, and fixed a lint error. |
Sometimes you don't yet have the PR, so supplying the PR number doesn't make sense in certain cases. This PR would allow omitting changelog entry, folks would have to do that manually. Happy to add test cases!