✨Source Microsoft Teams Migrate Python CDK to Low-code CDK #36223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Full test results from |
alafanechere
added
the
low-code-migration
|
Ready for review ✅ |
girarda
reviewed
Mar 28, 2024
| oss: | ||
| enabled: true | ||
| name: Microsoft Teams | ||
| releaseDate: 2024-04-18 |
There was a problem hiding this comment.
let's set this to 2020-12-21
| requester: | ||
| type: HttpRequester | ||
| url_base: https://graph.microsoft.com/v1.0/ | ||
| path: users?$top={{ config['page_size'] }} |
There was a problem hiding this comment.
let's set a default value
path: users?$top={{ config.get('page_size', 20) }}
| - client_secret | ||
| - period | ||
| - tenant_id | ||
| properties: |
There was a problem hiding this comment.
let's move these properties in a credentials block so it's compatible with the existing spec
There was a problem hiding this comment.
Done, It's backward compatible now
|
Inline schema ✅
|
|
Marking PR as ready to merge |
|
Continued in #36950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrating Source Microsoft Teams to Low-Code CDK
Closes airbytehq/airbyte-internal-issues#6812
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
spec.yamlmanifest.yamlschemas/*Tests
Integration & Acceptance
🚨 User Impact 🚨