Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帀 fix for filenames too long in local Win deployment #3625

Merged
merged 9 commits into from
May 26, 2021
Merged

馃帀 fix for filenames too long in local Win deployment #3625

merged 9 commits into from
May 26, 2021

Conversation

Phlair
Copy link
Contributor

@Phlair Phlair commented May 26, 2021

What

Cloning repo onto Windows hits errors for certain files having filename length too long. (see thread in slack issues here: https://airbytehq.slack.com/archives/C01MFR03D5W/p1621990489251100)

How

By changing a git config setting, this behaviour can be changed allowing longer filenames to work on Windows. I have updated the deploying locally on Windows documentation to show how to change this setting.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

@Phlair
Copy link
Contributor Author

Phlair commented May 26, 2021

@marcosmarxm

@marcosmarxm
Copy link
Member

This resolves #3607, thanks @Phlair

@marcosmarxm marcosmarxm added the area/documentation Improvements or additions to documentation label May 26, 2021
@marcosmarxm marcosmarxm requested review from avaidyanatha and removed request for michel-tricot and davinchia May 26, 2021 14:36
@Phlair
Copy link
Contributor Author

Phlair commented May 26, 2021

^ oops, should be back to expected now!

@marcosmarxm marcosmarxm changed the title fix for filenames too long in local Win deployment 馃帀 fix for filenames too long in local Win deployment May 26, 2021
@marcosmarxm marcosmarxm merged commit 44b8d93 into airbytehq:master May 26, 2021
@cgardens cgardens changed the title 馃帀 fix for filenames too long in local Win deployment 馃帀 fix for filenames too long in local Win deployment May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants