Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix flakiness #36258

Merged
merged 4 commits into from Mar 19, 2024
Merged

Attempt to fix flakiness #36258

merged 4 commits into from Mar 19, 2024

Conversation

xiaohansong
Copy link
Contributor

@xiaohansong xiaohansong commented Mar 18, 2024

The idea is because in the test we soft linked to a shared state message and modified it. That means other tests running after the modifying test would refer to incorrect data.

context: https://airbytehq-team.slack.com/archives/C02TYE9QL9M/p1710734475831149

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 11:01pm

@xiaohansong xiaohansong marked this pull request as ready for review March 18, 2024 22:26
@xiaohansong xiaohansong requested a review from a team as a code owner March 18, 2024 22:26
@xiaohansong xiaohansong merged commit bb478d5 into master Mar 19, 2024
29 checks passed
@xiaohansong xiaohansong deleted the xiaohan/deflake branch March 19, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants