Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Lever Hiring: migrate to low-code #36262

Merged
merged 16 commits into from May 10, 2024

Conversation

pabloescoder
Copy link
Collaborator

Migrating Source Lever Hiring to YamlDeclarativeSource (Low-code) Airbyte CDK
Resolves airbytehq/airbyte-internal-issues#6753

No breaking changes, I've tried to replicate everything that was there in the previous python based source. Since the source supported 2 methods of authentication, I used a SelectiveAuthenticator as suggested by @girarda to implement the same in low code.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 10:50pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 19, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team March 19, 2024 06:31
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 19, 2024 06:32
@alafanechere alafanechere added the low-code-migration This connector has been migrated to the low-code CDK label Mar 22, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 27, 2024 22:29
@pabloescoder
Copy link
Collaborator Author

Acceptance tests passing after fixing the cursor format and partitioning the stream into months
image

@pabloescoder pabloescoder changed the title 🚨🚨 Source Lever Hiring: migrate to low-code ✨Source Lever Hiring: migrate to low-code Apr 6, 2024
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small requests. can you also run airbyte-ci format fix all to fix the formatting?

@pabloescoder
Copy link
Collaborator Author

Made all the required changes and ran format fix all, all tests passing.
image

@lazebnyi lazebnyi requested a review from tolik0 April 22, 2024 13:21
@pabloescoder pabloescoder requested a review from tolik0 May 7, 2024 22:58
@tolik0 tolik0 merged commit 715bdae into master May 10, 2024
36 of 37 checks passed
@tolik0 tolik0 deleted the source-lever-hiring-migrate-to-low-code branch May 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/lever-hiring low-code-migration This connector has been migrated to the low-code CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants