Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[source-confluence] 'expand' request parameter converted to comma separated string #36339

Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 0 additions & 38 deletions airbyte-integrations/connectors/source-confluence/Dockerfile

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-confluence:dev
test_strictness_level: low
acceptance_tests:
spec:
tests:
Expand All @@ -18,9 +19,6 @@ acceptance_tests:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
expect_records:
path: "integration_tests/expected_records.jsonl"
fail_on_extra_columns: false
full_refresh:
tests:
- config_path: "secrets/config.json"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ data:
enabled: true
connectorSubtype: api
connectorType: source
connectorBuildOptions:
baseImage: docker.io/airbyte/python-connector-base:1.2.0@sha256:c22a9d97464b69d6ef01898edf3f8612dc11614f05a84984451dde195f337db9
definitionId: cf40a7f8-71f8-45ce-a7fa-fca053e4028c
dockerImageTag: 0.2.0
dockerImageTag: 0.2.1
dockerRepository: airbyte/source-confluence
documentationUrl: https://docs.airbyte.com/integrations/sources/confluence
githubIssueLabel: source-confluence
Expand Down
1,051 changes: 1,051 additions & 0 deletions airbyte-integrations/connectors/source-confluence/poetry.lock

Large diffs are not rendered by default.

30 changes: 30 additions & 0 deletions airbyte-integrations/connectors/source-confluence/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
[build-system]
requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "0.2.1"
name = "source-confluence"
description = "Source implementation for Confluence."
authors = [ "Airbyte <hey@airbyte.io>",]
license = "MIT"
readme = "README.md"
documentation = "https://docs.airbyte.com/integrations/sources/confluence"
homepage = "https://airbyte.com"
repository = "https://github.com/airbytehq/airbyte"
[[tool.poetry.packages]]
include = "source_confluence"

[tool.poetry.dependencies]
python = "^3.9,<3.12"
airbyte-cdk = "^0.73.0"


[tool.poetry.scripts]
source-confluence = "source_confluence.run:run"

[tool.poetry.group.dev.dependencies]
requests-mock = "^1.9.3"
pytest-mock = "^3.6.1"
pytest = "^6.2"
responses = "^0.13.3"
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ definitions:
requester:
$ref: "#/definitions/requester"
request_parameters:
expand: >-
["history","history.lastUpdated","history.previousVersion","history.contributors","restrictions.read.restrictions.user","version","descendants.comment","body","body.storage","body.view",]
expand: "history,history.lastUpdated,history.previousVersion,history.contributors,restrictions.read.restrictions.user,version,descendants.comment,body,body.storage,body.view"
primary_key: "id"
$parameters:
name: "blog_posts"
Expand All @@ -101,8 +100,7 @@ definitions:
requester:
$ref: "#/definitions/requester"
request_parameters:
expand: >-
["history","history.lastUpdated","history.previousVersion","history.contributors","restrictions.read.restrictions.user","version","descendants.comment","body","body.storage","body.view",]
expand: "history,history.lastUpdated,history.previousVersion,history.contributors,restrictions.read.restrictions.user,version,descendants.comment,body,body.storage,body.view"
primary_key: "id"
$parameters:
name: "pages"
Expand All @@ -115,7 +113,7 @@ definitions:
requester:
$ref: "#/definitions/requester"
request_parameters:
expand: '["permissions","icon","description.plain","description.view"]'
expand: "permissions,icon,description.plain,description.view"
primary_key: "id"
$parameters:
name: "space"
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/confluence.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ The Confluence connector should not run into Confluence API limitations under no

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :------------------------------------------------------------- |
| 0.2.1 | 2024-03-20 | [36339](https://github.com/airbytehq/airbyte/pull/36339) | 🐛 Source Confluence: 'expand' request parameter converted to comma separated string
| 0.2.0 | 2023-08-14 | [29125](https://github.com/airbytehq/airbyte/pull/29125) | Migrate Confluence Source Connector to Low Code |
| 0.1.3 | 2023-03-13 | [23988](https://github.com/airbytehq/airbyte/pull/23988) | Add view and storage to pages body, add check for stream Audit |
| 0.1.2 | 2023-03-06 | [23775](https://github.com/airbytehq/airbyte/pull/23775) | Set additionalProperties: true, update docs and spec |
Expand Down