Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maxSecondsBetweenMessages value for certified connectors Phase 1 #36382

Merged

Conversation

DanyloGL
Copy link
Contributor

@DanyloGL DanyloGL commented Mar 22, 2024

For certified connectors is requirement to have maxSecondsBetweenMessages set in metadata file.
maxSecondsBetweenMessages is the longest time frame (in seconds) of API requests limits reset for endpoints used by connector.

What

maxSecondsBetweenMessages value for the following connectors was added:

  • source-google-shhets: maxSecondsBetweenMessages: 60. Longest time frame of limits reset is 1 minute or 60 seconds
  • source-google-search-console: maxSecondsBetweenMessages: 86400. Longest time frame of limits reset is 1 day or 86400 seconds
  • source-hubspot: maxSecondsBetweenMessages: 86400. Longest time frame of limits reset is 1 day or 86400 seconds

How

Files metadata.yaml for connectors mentioned above were updated by adding maxSecondsBetweenMessages value.

🚨 User Impact 🚨

No breaking changes

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 9:34am

@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 22, 2024 16:37
@bazarnov bazarnov changed the title Set 'maxSecondsBetweenMessages' value for sertified connectors Phase 1 Set 'maxSecondsBetweenMessages' value for certified connectors Phase 1 Mar 22, 2024
@bazarnov bazarnov changed the title Set 'maxSecondsBetweenMessages' value for certified connectors Phase 1 Set maxSecondsBetweenMessages value for certified connectors Phase 1 Mar 22, 2024
@lazebnyi
Copy link
Collaborator

/approve-and-merge reason="batch changes of maxSecondsBetweenMessages in metadata.yaml files"

@octavia-approvington
Copy link
Contributor

Lets merge it
sheep thumbs up

@octavia-approvington octavia-approvington merged commit b7ba595 into master Mar 26, 2024
29 of 32 checks passed
@octavia-approvington octavia-approvington deleted the DanyloGL/maxSecondsBetweenMessages_value_adding_1 branch March 26, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants