New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Source Quickbooks: Update missing stream props and add token refresh udpater #36389
Merged
marcosmarxm
merged 10 commits into
airbytehq:master
from
henriblancke:fix-source-quickbooks-token-refresh
Apr 11, 2024
Merged
馃悰 Source Quickbooks: Update missing stream props and add token refresh udpater #36389
marcosmarxm
merged 10 commits into
airbytehq:master
from
henriblancke:fix-source-quickbooks-token-refresh
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Connector related issues
community
connectors/source/quickbooks
labels
Mar 22, 2024
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Mar 22, 2024
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
marcosmarxm
requested changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small details. I need to run tests but the change looks good.
airbyte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/bills.json
Show resolved
Hide resolved
...yte-integrations/connectors/source-quickbooks/source_quickbooks/schemas/journal_entries.json
Show resolved
Hide resolved
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
Having a hard time running tests to release this change. Hope to get something today/tmw |
marcosmarxm
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/source/quickbooks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
bills
,deposits
andjournal_entries
streamsmanifest.json
to include therefresh_token_updater
so new refresh tokens get picked up and stored in config