Zendesk Support: Unpin CDK

[ChristoGrab]

What

• Unpinned the CDK version for source Zendesk Support
• Updated failing test assertions
• Increased timeout for incremental tests due to failing test_sequential_read test.

Note: Incremental Substream Bug 🐛🚨

I encountered a bug in the connector that I believe is due to incremental substreams using the same logic for handling stream state as top-level incremental streams (ie, a single cursor value as opposed to per-partition keys). This logic can lead to records being dropped during incremental syncs, as is the case with one of the expected records for the article_comment_votes stream. This stream has two records in our sandbox. Comparing the two existing article_comment_votes timestamps:

{"updated_at": "2023-06-22T00:33:42Z"} -> This record gets read and updates state
{"updated_at": "2023-06-22T00:33:40Z"} -> This record is skipped despite having never been read

Although this is the only stream that threw an expected_records failure, all incremental substreams use this same logic, and as such are affected. However, given that:

1. The fix will constitute a breaking change
2. This connector is slated to be migrated to low-code in the next round of migrations, and the switch to per-partition state is a natural outcome of that migration

I think the best plan of action is to ship the CDK update, and allow the fix to be included in the upcoming migration. I've created an issue to track this for visibility.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 29, 2024 4:31pm

[brianjlai]

lgtm and I agree with your assessment. Thanks for meticulously researching this and for the follow up ticket. great work!