Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Rss: Migrate Python CDK to Low-code CDK #36418

Merged
merged 18 commits into from Apr 10, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

Migrating Source Rss to Low-Code CDK
Closes airbytehq/airbyte-internal-issues#6952

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

Tests

Integration & Acceptance
  • Full passed state:

image

🚨 User Impact 🚨

  • Spec Breaking changes, migration to low-code

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 3:36am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/rss labels Mar 23, 2024
@btkcodedev
Copy link
Collaborator Author

image

The full refresh is passing
Incremental sync DateTimeCursor would not be required as it is custom parsed as incremental in custom component

Tested config URL: {
"url": "https://www.nasa.gov/rss/dyn/breaking_news.rss"
}

Thanks!

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: I removed the reference to the expected records file because it didn't exist. Looks great otherwise!

@alafanechere alafanechere added the low-code-migration This connector has been migrated to the low-code CDK label Apr 3, 2024
@girarda
Copy link
Contributor

girarda commented Apr 5, 2024

@btkcodedev , there are 3 failures in CI

source-rss - ❌ Failed - Breaking changes must be accompanied by a migration guide: Migration guide file is missing for source-rss. Please create a migration guide in ./docs/integrations/<connector-type>s/<connector-name>-migrations.md`.
source-rss - ❌ Failed - Connectors must use Poetry for dependency management: poetry.lock file is missing.
source-rss - ❌ Failed - Connector version in metadata.yaml and pyproject.toml file must match: Version is 1.0.0 in metadata.yaml, but version is 0.1.0 in pyproject.toml. These two files have to be consistent.
Error: 3 checks failed

Let me know if you have questions. Otherwise, please fix them and I'll release the connector 🚀

@btkcodedev
Copy link
Collaborator Author

@girarda Resolved the issues, Please continue the merge 🙇‍♂️
Latest test results: All pass
image

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run airbyte-ci format fix all and commit the changes? then we'll be good to 🚢

releases:
breakingChanges:
1.0.0:
upgradeDeadline: "2024-04-15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's set this to the end of the month

@btkcodedev
Copy link
Collaborator Author

@girarda All comments resolved, formatted and updated
Please continue review process,
Format results - full pass
image

arbyte-ci test results - Full pass
image

@girarda girarda merged commit bc27a84 into airbytehq:master Apr 10, 2024
47 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/rss low-code-migration This connector has been migrated to the low-code CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants