Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): rename partial_message package #36447

Merged

Conversation

jdpgrailsdev
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev commented Mar 25, 2024

Renames the partial_message package to model to avoid discouraged characters in package names in Kotlin. There is no functional change in this PR, just the rename of the package and fallout from that change.

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 8:43pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Mar 25, 2024
Copy link
Contributor Author

jdpgrailsdev commented Mar 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jdpgrailsdev and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a safe-enough find/replace to me!

@jdpgrailsdev jdpgrailsdev force-pushed the jonathan/03-25-feat_cdk_rename_partial_message_package branch 7 times, most recently from f2abf67 to bd3b358 Compare March 28, 2024 13:40
@jdpgrailsdev jdpgrailsdev force-pushed the jonathan/03-25-feat_cdk_rename_partial_message_package branch from bd3b358 to ea9ca56 Compare March 28, 2024 20:42
Copy link
Contributor Author

jdpgrailsdev commented Mar 29, 2024

Merge activity

@jdpgrailsdev jdpgrailsdev merged commit 9c52800 into master Mar 29, 2024
31 checks passed
@jdpgrailsdev jdpgrailsdev deleted the jonathan/03-25-feat_cdk_rename_partial_message_package branch March 29, 2024 13:59
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
Renames the `partial_message` package to `model` to avoid discouraged characters in package names in Kotlin.  There is no functional change in this PR, just the rename of the package and fallout from that change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants