Source Sendgrid: unpin CDK version #36455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
brianjlai
approved these changes
Mar 26, 2024
| @@ -18,7 +18,7 @@ acceptance_tests: | |||
| status: "failed" | |||
| discovery: | |||
| tests: | |||
| - config_path: "secrets/old_config.json" | |||
| - config_path: "secrets/config.json" | |||
There was a problem hiding this comment.
Noting that there seemed to be a very conscious change to switch from config.json to old_config.json in this PR back in 2022. The only difference in the files I pulled from GCS is start_time changing from "2019-05-20T13:43:57.000Z" to "2019-05-20T13:43:57Z".
But since it looks like CI tests are passing just fine now, I'm good with the change and thanks for updating. Just adding context in case.
There was a problem hiding this comment.
Gotcha, thanks for double-checking to verify!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
airbyte-cdkversion and removed dependencies that come packaged with it frompyproject.tomlold-configtoconfigfor consistency